Skip to content

[stable2509] Backport #10323#10326

Merged
EgorPopelyaev merged 5 commits intostable2509from
backport-10323-to-stable2509
Nov 19, 2025
Merged

[stable2509] Backport #10323#10326
EgorPopelyaev merged 5 commits intostable2509from
backport-10323-to-stable2509

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #10323 into stable2509 from EgorPopelyaev.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Copy Markdown
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-10323-to-stable2509
git worktree add --checkout .worktree/backport-10323-to-stable2509 backport-10323-to-stable2509
cd .worktree/backport-10323-to-stable2509
git reset --hard HEAD^
git cherry-pick -x d393f375cd06cc7d898baf9aea4dccc08dc430b6
git push --force-with-lease

@github-actions github-actions Bot added the A3-backport Pull request is already reviewed well in another branch. label Nov 14, 2025
This reverts commit 1ebcb0e.
This PR adds couple of improvements to the Check semver job for the
stable branches:
1. The `validate: false` option can be set now not only on the `mojor`
bumps but on the `minor` and `patch` as well, this one is useful when
for the backport cases when a desired bump does not match with the one,
that `parity-publish` semver check has predicted (like
[here](https://github.com/paritytech/polkadot-sdk/actions/runs/19135068993/job/54685184577?pr=10221))
2. Possibility to skip check, when it is really not needed but still
fails (like on the post crates release
[prs](https://github.com/paritytech/polkadot-sdk/actions/runs/18311557391/job/52141285274?pr=9951))

closes: paritytech/release-engineering#274
@EgorPopelyaev EgorPopelyaev marked this pull request as ready for review November 19, 2025 09:15
@EgorPopelyaev EgorPopelyaev requested review from a team as code owners November 19, 2025 09:15
@EgorPopelyaev EgorPopelyaev added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Nov 19, 2025
@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) November 19, 2025 09:16
@paritytech-review-bot paritytech-review-bot Bot requested a review from a team November 19, 2025 09:16
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@paritytech-workflow-stopper
Copy link
Copy Markdown

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/19496402543
Failed job name: build-templates-node

@EgorPopelyaev EgorPopelyaev merged commit fd902fc into stable2509 Nov 19, 2025
270 of 275 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-10323-to-stable2509 branch November 19, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch. R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant